Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752481AbdFOIRP (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Jun 2017 04:17:15 -0400
Received: from mail-it0-f49.google.com ([209.85.214.49]:34932 "EHLO
        mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752051AbdFOIRN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Jun 2017 04:17:13 -0400
MIME-Version: 1.0
In-Reply-To: <20170614082330.nshvjidl3zq37bvz@mwanda>
References: <20170613223702.534373529@gmail.com> <20170613224050.646277124@gmail.com>
 <20170614082330.nshvjidl3zq37bvz@mwanda>
From: Okash Khawaja <okash.khawaja@gmail.com>
Date: Thu, 15 Jun 2017 09:17:12 +0100
Message-ID: <CAOtcWM1MfnpGW+ZxnfkXUvMX5caPQtBHbOws1qk17ROqXoCQhQ@mail.gmail.com>
Subject: Re: [patch 1/2] staging: speakup: add function to convert dev name to number
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        Kirk Reiser <kirk@reisers.ca>,
        "Speakup is a screen review system for Linux." 
        <speakup@linux-speakup.org>,
        Chris Brannon <chris@the-brannons.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 272
Lines: 11

Hi,

On Wed, Jun 14, 2017 at 9:23 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
[...]
>
> Could you call it "dev_name" instead?  I normally expect "dev" to be a
> device struct.

Thanks for the feedback. Will keep these in mind for next version of the patch.

Okash