Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752310AbdFOI6S (ORCPT ); Thu, 15 Jun 2017 04:58:18 -0400 Received: from mail-ve1eur01on0089.outbound.protection.outlook.com ([104.47.1.89]:7059 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750784AbdFOI6Q (ORCPT ); Thu, 15 Jun 2017 04:58:16 -0400 From: Bogdan Purcareata To: Ruxandra Ioana Radulescu , "gregkh@linuxfoundation.org" CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "agraf@suse.de" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "stuyoder@gmail.com" , Laurentiu Tudor , "Ruxandra Ioana Radulescu" , Roy Pledge , Haiying Wang Subject: RE: [PATCH] staging: fsl-mc/dpio: Propagate error code Thread-Topic: [PATCH] staging: fsl-mc/dpio: Propagate error code Thread-Index: AQHS5bUZ3DPTbNR5GUaZsOfMx81+oKIln1rQ Date: Thu, 15 Jun 2017 08:58:10 +0000 Message-ID: References: <20170615085506.31784-1-ruxandra.radulescu@nxp.com> In-Reply-To: <20170615085506.31784-1-ruxandra.radulescu@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.88.146.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0401MB1853;7:Y7i3lzE7StPcWjZr+QrN7OXIyV4oUV988+0RRjGRMs5wMvnKIiZKpW6dVOoDy3Nva/r9xoiY7g+TPFnsq6zadpGX92AWlDS8ggZPClGh3CceyB4LRZcvdp5BRQo8iD9nE1C9r88i1UYbmIJIfOlj5RC7dcqP0A1Q0LPdnwYWBnOw9jAM8REPaM7ylhusLbuc/w0ZgaG7ATnlxOKUCuXQGc0VeASgUdchnCIQRA6oqirsKY2YSDuC3CpM4NXdsl79nImWIZTiSOgf9qiFS7MHAiyKhO/DR8RdcWFfv2VGYSwkd/i3328LPe14aJDUSmdXNrF/z0L4Pkco+a2rGl2ieg== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39410400002)(39400400002)(39850400002)(39450400003)(39860400002)(13464003)(377454003)(2906002)(229853002)(66066001)(3660700001)(478600001)(3280700002)(3846002)(7736002)(8676002)(8936002)(6116002)(5660300001)(102836003)(305945005)(81166006)(74316002)(54356999)(4326008)(53936002)(86362001)(76176999)(9686003)(14454004)(2501003)(25786009)(53546009)(5250100002)(6246003)(6506006)(99286003)(55016002)(50986999)(7696004)(38730400002)(189998001)(6436002)(2950100002)(54906002)(2900100001)(33656002)(39060400002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB1853;H:DB5PR04MB1240.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; x-ms-traffictypediagnostic: VI1PR0401MB1853: x-ms-office365-filtering-correlation-id: d6f8e004-24c9-4f3e-6e4e-08d4b3cca688 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:VI1PR0401MB1853; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0401MB1853;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0401MB1853; x-forefront-prvs: 0339F89554 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2017 08:58:11.3741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1853 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5F8wWrb029698 Content-Length: 1779 Lines: 47 > -----Original Message----- > From: Ioana Radulescu [mailto:ruxandra.radulescu@nxp.com] > Sent: Thursday, June 15, 2017 11:55 AM > To: gregkh@linuxfoundation.org > Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; > agraf@suse.de; arnd@arndb.de; linux-arm-kernel@lists.infradead.org; Bogdan > Purcareata ; stuyoder@gmail.com; Laurentiu Tudor > ; Ruxandra Ioana Radulescu > ; Roy Pledge ; Haiying Wang > > Subject: [PATCH] staging: fsl-mc/dpio: Propagate error code > > dpaa2_io_service_register() returns zero even if > qbman_swp_CDAN_set() encountered an error. Fix this > by propagating the error code so the caller is informed > data availability notifications are not properly set > for a channel. > > Signed-off-by: Ioana Radulescu Acked-by: Bogdan Purcareata > --- > drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c > b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c > index e5d66749614c..762f045f53f7 100644 > --- a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c > +++ b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c > @@ -260,9 +260,9 @@ int dpaa2_io_service_register(struct dpaa2_io *d, > > /* Enable the generation of CDAN notifications */ > if (ctx->is_cdan) > - qbman_swp_CDAN_set_context_enable(d->swp, > - (u16)ctx->id, > - ctx->qman64); > + return qbman_swp_CDAN_set_context_enable(d->swp, > + (u16)ctx->id, > + ctx->qman64); > return 0; > } > EXPORT_SYMBOL(dpaa2_io_service_register); > -- > 2.11.0