Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752148AbdFOJhv (ORCPT ); Thu, 15 Jun 2017 05:37:51 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:55553 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbdFOJhu (ORCPT ); Thu, 15 Jun 2017 05:37:50 -0400 Date: Thu, 15 Jun 2017 11:37:48 +0200 From: Boris Brezillon To: Peter Rosin , Nicolas Ferre Cc: linux-kernel@vger.kernel.org, Peter Rosin , David Airlie , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: atmel-hlcdc: sama5d4 does not have overlay2 Message-ID: <20170615113748.1c98f898@bbrezillon> In-Reply-To: <1497518653-2788-1-git-send-email-peda@lysator.liu.se> References: <1497518653-2788-1-git-send-email-peda@lysator.liu.se> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1649 Lines: 55 On Thu, 15 Jun 2017 11:24:13 +0200 Peter Rosin wrote: > From: Peter Rosin > > Remove the layer. Duh. It was present in the datasheet I had. Just downloaded last version of the datasheet and it's no longer there. Nicolas, there's still a reference to OVR2 in the block diagram (Section "31.3 Block Diagram"), can ask fix that (or ask someone who can). > > Fixes: 5b9fb5e6c6c7 ("drm: atmel-hlcdc: add support for sama5d4 SoCs") > Signed-off-by: Peter Rosin > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > index 30dbffd..888524a 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > @@ -295,28 +295,10 @@ static const struct atmel_hlcdc_layer_desc atmel_hlcdc_sama5d4_layers[] = { > }, > }, > { > - .name = "overlay2", > - .formats = &atmel_hlcdc_plane_rgb_formats, > - .regs_offset = 0x240, > - .id = 2, > - .type = ATMEL_HLCDC_OVERLAY_LAYER, > - .cfgs_offset = 0x2c, > - .layout = { > - .pos = 2, > - .size = 3, > - .xstride = { 4 }, > - .pstride = { 5 }, > - .default_color = 6, > - .chroma_key = 7, > - .chroma_key_mask = 8, > - .general_config = 9, > - }, > - }, > - { > .name = "high-end-overlay", > .formats = &atmel_hlcdc_plane_rgb_and_yuv_formats, > .regs_offset = 0x340, > - .id = 3, > + .id = 2, > .type = ATMEL_HLCDC_OVERLAY_LAYER, > .cfgs_offset = 0x4c, > .layout = {