Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751976AbdFOJx6 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Jun 2017 05:53:58 -0400
Received: from bh-25.webhostbox.net ([208.91.199.152]:58752 "EHLO
        bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750784AbdFOJx5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Jun 2017 05:53:57 -0400
Subject: Re: Qemu crashes in -next due to 'of: remove *phandle properties from
 expanded device tree'
To: Frank Rowand <frowand.list@gmail.com>
Cc: Frank Rowand <frank.rowand@sony.com>, linux-kernel@vger.kernel.org,
        Rob Herring <robh@kernel.org>
References: <20170614192638.GA15210@roeck-us.net> <5941AB4E.3070804@gmail.com>
 <20170614223559.GA19172@roeck-us.net> <5941D8C0.1020100@gmail.com>
 <f994f1ab-64dc-85b6-da4d-9c332d9578a3@roeck-us.net>
 <59423E1C.4020804@gmail.com>
From: Guenter Roeck <linux@roeck-us.net>
Message-ID: <0503891a-a50a-b12a-84b6-dd98e8c6a000@roeck-us.net>
Date: Thu, 15 Jun 2017 02:53:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <59423E1C.4020804@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net
X-AntiAbuse: Original Domain - vger.kernel.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - roeck-us.net
X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net
X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2038
Lines: 66

On 06/15/2017 12:58 AM, Frank Rowand wrote:
> On 06/14/17 21:12, Guenter Roeck wrote:
> 
> < snip >
> 
>> Good (v4.12-rc4):
>>
> 
> < snip >
> 
>> OF: Checking node /soc@e0000000/pic@40000
>> OF:     type match
>> OF:   node '/soc@e0000000/pic@40000' compatible '' type 'open-pic' name '' score 2
>> OF:   node '/soc@e0000000/pic@40000' compatible 'open-pic' type '' name '' score 0
> 
> < snip >
> 
>>
>> bad:
> 
> < snip >
> 
>> OF: Checking node /soc@e0000000/pic@40000
>> OF:   node '/soc@e0000000/pic@40000' compatible '' type 'open-pic' name '' score 0
>> OF:   node '/soc@e0000000/pic@40000' compatible 'open-pic' type '' name '' score 0
> 
> < snip >
> 
>> No matching open-pic node
>> ------------[ cut here ]------------
>> kernel BUG at arch/powerpc/platforms/85xx/corenet_generic.c:50!
>>
>> So, in __of_device_is_compatible(), the difference is in
>> __of_device_is_compatible() after
>>
>>          /* Matching type is better than matching name */
>>
>> Further debugging shows that device->type is NULL in the bad case.
>>
>> OF: Checking node /soc@e0000000/pic@40000
>> OF:     trying type match open-pic - <NULL>
>> OF:   node '/soc@e0000000/pic@40000' compatible '' type 'open-pic' name '' score 0
>> OF:   node '/soc@e0000000/pic@40000' compatible 'open-pic' type '' name '' score 0
>>
>> Do you need more information ?
> 
> I think I know what part of my patch is causing the problem.
> 
> Can you try the following patch to see if if fixes the failure in
> __of_device_is_compatible()?
> 
> If this fixes the failure, then I know what is going on.  If it works
> then I will have to rework my original patch in a different way than
> this quick hack.
> 

Sorry, doesn't make a difference.

OF: Checking node /soc@e0000000/pic@40000
OF:     trying type match open-pic - <NULL>
OF:   node '/soc@e0000000/pic@40000' compatible '' type 'open-pic' name '' score 0
OF:   node '/soc@e0000000/pic@40000' compatible 'open-pic' type '' name '' score 0

I added a log message into __of_attach_node(); it is not called.

Guenter