Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752094AbdFOKlw (ORCPT ); Thu, 15 Jun 2017 06:41:52 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:34360 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbdFOKlv (ORCPT ); Thu, 15 Jun 2017 06:41:51 -0400 Date: Thu, 15 Jun 2017 12:41:42 +0200 From: Dawid Kurek To: Daniel Vetter , Jani Nikula , Sean Paul , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm: Reduce scope of 'state' variable Message-ID: <20170615104142.GA29276@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) X-Antivirus: Avast (VPS 170615-0, 15/06/2017), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 927 Lines: 31 Smaller scope reduces visibility of variable and makes usage of uninitialized variable less possible. --- drivers/gpu/drm/drm_atomic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index f32506a..ea5a9a7 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -108,10 +108,11 @@ struct drm_atomic_state * drm_atomic_state_alloc(struct drm_device *dev) { struct drm_mode_config *config = &dev->mode_config; - struct drm_atomic_state *state; if (!config->funcs->atomic_state_alloc) { - state = kzalloc(sizeof(*state), GFP_KERNEL); + struct drm_atomic_state *state + = kzalloc(sizeof(*state), GFP_KERNEL); + if (!state) return NULL; if (drm_atomic_state_init(dev, state) < 0) { -- 2.10.0 --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus