Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752552AbdFONPg (ORCPT ); Thu, 15 Jun 2017 09:15:36 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:35962 "EHLO mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbdFONPe (ORCPT ); Thu, 15 Jun 2017 09:15:34 -0400 MIME-Version: 1.0 In-Reply-To: <20170615075059.GD5902@dragon> References: <1491501735-1649-1-git-send-email-jagan@openedev.com> <1491501735-1649-2-git-send-email-jagan@openedev.com> <20170407131649.GH16503@dragon> <20170615022024.GE30112@dragon> <20170615071529.GC5902@dragon> <20170615075059.GD5902@dragon> From: Jagan Teki Date: Thu, 15 Jun 2017 18:45:32 +0530 Message-ID: Subject: Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node To: Shawn Guo Cc: Jagan Teki , linux-arm-kernel , devicetree , linux-kernel , Sascha Hauer , Fabio Estevam , Matteo Lisi , Michael Trimarchi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1428 Lines: 36 On Thu, Jun 15, 2017 at 1:21 PM, Shawn Guo wrote: > On Thu, Jun 15, 2017 at 01:01:22PM +0530, Jagan Teki wrote: >> > I feel the abstraction is wrong from the beginning. Ideally, we should >> > have something like below. >> > >> > - imx6ul-isiot.dtsi >> > - imx6ul-isiot-kit.dts and imx6ul-isiot-carrier.dts >> > >> > The -isiot should have everything on SoM and common stuff between -kit >> > and -carrier boards, while -kit and -carrier include -isiot and contains >> > the base-board specific things. The -isiot can have both emmc and nand >> > devices with "disabled" status, and let firmware turn device on per SoM >> > it boots. In that case, the abstraction level can be less and clearer. >> > >> > Thoughts? >> >> So,even the common stuff (lcdif, ts and etc) should be in -isiot.dtsi > > Yes, anything common can be in -isiot.dtsi. > >> and make it "disabled" and let them enabled on respective dts. this >> what you mentioned here? > > It doesn't matter. If the lcd/touch is same on -kit and -carrier, you > can even have them enabled by default in -isiot.dtsi. The -kit.dts and > -carrier.dts are there to accommodate base-board specific differences. OK, thanks for the help. I'll resolve and send v4 changes by breaking this series for each respective modules. thanks! -- Jagan Teki Senior Linux Kernel Engineer | Amarula Solutions U-Boot, Linux | Upstream Maintainer Hyderabad, India.