Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873AbdFOO4g (ORCPT ); Thu, 15 Jun 2017 10:56:36 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57190 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752836AbdFOO4d (ORCPT ); Thu, 15 Jun 2017 10:56:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 280E460850 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Andrey Ryabinin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Arend van Spriel , Franky Lin , Hante Meuleman , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com Subject: Re: [PATCH v2 08/11] brcmsmac: make some local variables 'static const' to reduce stack size References: <20170614211556.2062728-1-arnd@arndb.de> <20170614211556.2062728-9-arnd@arndb.de> Date: Thu, 15 Jun 2017 17:56:27 +0300 In-Reply-To: <20170614211556.2062728-9-arnd@arndb.de> (Arnd Bergmann's message of "Wed, 14 Jun 2017 23:15:43 +0200") Message-ID: <87mv99e1us.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1066 Lines: 23 Arnd Bergmann writes: > With KASAN and a couple of other patches applied, this driver is one > of the few remaining ones that actually use more than 2048 bytes of > kernel stack: > > broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy_gainctrl': > broadcom/brcm80211/brcmsmac/phy/phy_n.c:16065:1: warning: the frame size of 3264 bytes is larger than 2048 bytes [-Wframe-larger-than=] > broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy': > broadcom/brcm80211/brcmsmac/phy/phy_n.c:17138:1: warning: the frame size of 2864 bytes is larger than 2048 bytes [-Wframe-larger-than=] > > Here, I'm reducing the stack size by marking as many local variables as > 'static const' as I can without changing the actual code. > > Acked-by: Arend van Spriel > Signed-off-by: Arnd Bergmann I found the cover letter from lkml and apparently the plan is that Andrew will pick these three brcmsmac patches, so I'll drop them in wireless patchwork. -- Kalle Valo