Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753067AbdFOPKU (ORCPT ); Thu, 15 Jun 2017 11:10:20 -0400 Received: from mga04.intel.com ([192.55.52.120]:22589 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752671AbdFOPKT (ORCPT ); Thu, 15 Jun 2017 11:10:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,343,1493708400"; d="scan'208";a="1141600090" Date: Thu, 15 Jun 2017 08:10:18 -0700 From: Andi Kleen To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, mingo@elte.hu, kan.liang@intel.com, jolsa@redhat.com Subject: Re: [PATCH 0/5] perf: add support for capturing skid IP Message-ID: <20170615151018.GA4789@tassilo.jf.intel.com> References: <1497534989-29231-1-git-send-email-eranian@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497534989-29231-1-git-send-email-eranian@google.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 462 Lines: 13 On Thu, Jun 15, 2017 at 06:56:24AM -0700, Stephane Eranian wrote: > This patchs adds a new sample record type called > PERF_SAMPLE_SKID_IP. The goal is to record > the unmodified interrupted instruction pointer (IP) as seen by > the kernel and reflected in the machine state. Patches look reasonable for me. If you only cared about branches it would be more natural to model it like a 1 entry LBR. That would make a lot more tooling work automatically. -Andi