Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbdFOPLP (ORCPT ); Thu, 15 Jun 2017 11:11:15 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:54320 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752687AbdFOPLO (ORCPT ); Thu, 15 Jun 2017 11:11:14 -0400 Date: Thu, 15 Jun 2017 11:11:11 -0400 (EDT) Message-Id: <20170615.111111.1375437088749599511.davem@davemloft.net> To: arvind.yadav.cs@gmail.com Cc: herbert@gondor.apana.org.au, tglx@linutronix.de, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: n2: make of_device_ids const From: David Miller In-Reply-To: <9ab9e99928c8add9d11779c5f5a267f10f166875.1497527778.git.arvind.yadav.cs@gmail.com> References: <9ab9e99928c8add9d11779c5f5a267f10f166875.1497527778.git.arvind.yadav.cs@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 15 Jun 2017 07:29:31 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 18 From: Arvind Yadav Date: Thu, 15 Jun 2017 17:28:10 +0530 > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 2001 2168 48 4217 1079 drivers/crypto/n2_core.o > > File size after constify dummy_tlb_ops.: > text data bss dec hex filename > 3601 536 48 4185 1059 drivers/crypto/n2_core.o > > Signed-off-by: Arvind Yadav Acked-by: David S. Miller