Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753105AbdFOPQe (ORCPT ); Thu, 15 Jun 2017 11:16:34 -0400 Received: from esa5.dell-outbound.iphmx.com ([68.232.153.95]:62949 "EHLO esa5.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbdFOPQc (ORCPT ); Thu, 15 Jun 2017 11:16:32 -0400 From: X-LoopCount0: from 10.170.28.40 X-IronPort-AV: E=Sophos;i="5.39,343,1493701200"; d="scan'208";a="1121088186" To: , CC: , , , Subject: RE: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Thread-Topic: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Thread-Index: AQHS5d+kk/AocFU6lEu7pmrbLSyJ6aImB6YA Date: Thu, 15 Jun 2017 15:16:15 +0000 Message-ID: <8c0becdd535d4a58b5dbc72eda082e12@ausx13mpc120.AMER.DELL.COM> References: <1495886134-8276-1-git-send-email-pali.rohar@gmail.com> <201706102115.57995@pali> <20170613164951.GI27850@fury> <201706132004.58051@pali> <20170613184228.GC22450@fury> <20170614154654.GA22981@pali> <20170615135902.GS5248@pali> In-Reply-To: <20170615135902.GS5248@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5FFGh5N023730 Content-Length: 1831 Lines: 50 > -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@gmail.com] > Sent: Thursday, June 15, 2017 8:59 AM > To: Limonciello, Mario ; Darren Hart > > Cc: Andy Shevchenko ; Andy Lutomirski ; > platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance > number > > Mario, are you able to check if instance number passed to > wmi_evaluate_method in following dell WMI drivers is correct and should > be really 1? > > I suspect that it should be zero, as instance number is indexed from > zero. > > There is no comment in those dell WMI drivers why it is 1, nor what 1 > means. > > Ideally it needs to be checked in ACPI byte code, MOF file and WDG dump. > I think you're likely correct. I don't have a box that supports alienware-wmi or dell-wmi-led.c handy at the current moment to confirm this hypothesis though. I'll confirm this later. I didn't realize it was zero indexed when I wrote alienware-wmi, and I'm guessing the author of dell-wmi-led didn't either. The reason it's probably working is the ACPI byte code isn't actually checking the instance since most times _WDG will only call out one instance. > On Wednesday 14 June 2017 17:46:54 Pali Rohár wrote: > > Function wmi_evaluate_method: > ... > > alienware-wmi.c: > > instance=1 /* no comment why, guid=A70591CE-A997-11DA-B012- > B622A1EF5492 */ > > instance=1 /* no comment why, guid=A80593CE-A997-11DA-B012- > B622A1EF5492 */ > > instance=1 /* no comment why, guid=A70591CE-A997-11DA-B012- > B622A1EF5492 */ > ... > > dell-wmi-led.c: > > instance=1 /* no comment why, guid=F6E4FE6E-909D-47cb-8BAB- > C9F6F2F8D396 */ > > -- > Pali Rohár > pali.rohar@gmail.com