Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901AbdFOPj0 (ORCPT ); Thu, 15 Jun 2017 11:39:26 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:33999 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbdFOPjZ (ORCPT ); Thu, 15 Jun 2017 11:39:25 -0400 MIME-Version: 1.0 In-Reply-To: <47616d54-283b-b661-3d10-8693b8251c56@arm.com> References: <1497492952-23877-1-git-send-email-chenhc@lemote.com> <1497493868-2446-1-git-send-email-chenhc@lemote.com> <20170615114156.GA4304@linux-mips.org> <47616d54-283b-b661-3d10-8693b8251c56@arm.com> From: Huacai Chen Date: Thu, 15 Jun 2017 23:39:23 +0800 X-Google-Sender-Auth: FhR_X6ESzZMmqVfZnurcqVa8B70 Message-ID: Subject: Re: [PATCH V5 6/9] MIPS: Loongson-3: support irq_set_affinity() in i8259 chip To: Marc Zyngier Cc: Ralf Baechle , John Crispin , "Steven J . Hill" , Linux MIPS Mailing List , Fuxin Zhang , Zhangjin Wu , Thomas Gleixner , Jason Cooper , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3390 Lines: 93 OK, I'll update my patch and set it at runtime. Huacai On Thu, Jun 15, 2017 at 9:15 PM, Marc Zyngier wrote: > Thanks Ralf. > > On 15/06/17 12:41, Ralf Baechle wrote: >> On Thu, Jun 15, 2017 at 10:31:05AM +0800, Huacai Chen wrote: >> >>> With this patch we can set irq affinity via procfs, so as to improve >>> network performance. >>> >>> Signed-off-by: Huacai Chen >>> --- >>> arch/mips/include/asm/irq.h | 3 ++ >>> arch/mips/loongson64/loongson-3/irq.c | 62 +++++++++++++++++++++++++++-------- >>> drivers/irqchip/irq-i8259.c | 3 ++ >>> 3 files changed, 55 insertions(+), 13 deletions(-) >> >> You didn't cc the IRQCHIP maintainers: >> >> IRQCHIP DRIVERS >> M: Thomas Gleixner >> M: Jason Cooper >> M: Marc Zyngier >> L: linux-kernel@vger.kernel.org >> S: Maintained >> T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core >> T: git git://git.infradead.org/users/jcooper/linux.git irqchip/core >> F: Documentation/devicetree/bindings/interrupt-controller/ >> F: drivers/irqchip/ >> >> Ralf >> >> >>> diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h >>> index ddd1c91..47ff7c6 100644 >>> --- a/arch/mips/include/asm/irq.h >>> +++ b/arch/mips/include/asm/irq.h >>> @@ -53,6 +53,7 @@ static inline int irq_canonicalize(int irq) >>> #define irq_canonicalize(irq) (irq) /* Sane hardware, sane code ... */ >>> #endif >>> >>> +struct irq_data; >>> asmlinkage void plat_irq_dispatch(void); >>> >>> extern void do_IRQ(unsigned int irq); >>> @@ -63,6 +64,8 @@ extern void spurious_interrupt(void); >>> extern int allocate_irqno(void); >>> extern void alloc_legacy_irqno(void); >>> extern void free_irqno(unsigned int irq); >>> +extern int plat_set_irq_affinity(struct irq_data *d, >>> + const struct cpumask *affinity, bool force); >>> >>> /* >>> * Before R2 the timer and performance counter interrupts were both fixed to >>> diff --git a/arch/mips/loongson64/loongson-3/irq.c b/arch/mips/loongson64/loongson-3/irq.c >>> index 2e6e205..e8b7a47 100644 >>> --- a/arch/mips/loongson64/loongson-3/irq.c >>> +++ b/arch/mips/loongson64/loongson-3/irq.c > > [...] > > Not going to comment on the Loongson-specific code which doesn't make > much sense to me (the patch doesn't explain anything about what it is > actually doing), but... > >>> diff --git a/drivers/irqchip/irq-i8259.c b/drivers/irqchip/irq-i8259.c >>> index 1aec12c..95d21e3 100644 >>> --- a/drivers/irqchip/irq-i8259.c >>> +++ b/drivers/irqchip/irq-i8259.c >>> @@ -46,6 +46,9 @@ static struct irq_chip i8259A_chip = { >>> .irq_disable = disable_8259A_irq, >>> .irq_unmask = enable_8259A_irq, >>> .irq_mask_ack = mask_and_ack_8259A, >>> +#ifdef CONFIG_CPU_LOONGSON3 >>> + .irq_set_affinity = plat_set_irq_affinity, >>> +#endif >>> }; > > ... that's a pretty horrible way of hooking up inside a random driver. > > Doesn't MIPS have some form of multi-platform kernel? If you need to add > something like this, it'd be better to set it at runtime, once you've > made sure that you're on the relevant HW (and preferably using an accessor). > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... >