Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751980AbdFOR0C (ORCPT ); Thu, 15 Jun 2017 13:26:02 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:43018 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbdFOR0B (ORCPT ); Thu, 15 Jun 2017 13:26:01 -0400 Date: Thu, 15 Jun 2017 10:25:59 -0700 From: Guenter Roeck To: Arvind Yadav Cc: wim@iguana.be, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] watchdog: bcm47xx_wdt: constify bcm47xx_wdt_hard_ops and bcm47xx_wdt_soft_ops Message-ID: <20170615172559.GB7549@roeck-us.net> References: <09f03198797fa7041adfab96811c059e50f44171.1497248301.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09f03198797fa7041adfab96811c059e50f44171.1497248301.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 46 On Mon, Jun 12, 2017 at 11:50:26AM +0530, Arvind Yadav wrote: > File size before: > text data bss dec hex filename > 1282 388 1 1671 687 drivers/watchdog/bcm47xx_wdt.o > > File size After adding 'const': > text data bss dec hex filename > 1474 196 1 1671 687 drivers/watchdog/bcm47xx_wdt.o > > Signed-off-by: Arvind Yadav Reviewed-by: Guenter Roeck > --- > drivers/watchdog/bcm47xx_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/bcm47xx_wdt.c b/drivers/watchdog/bcm47xx_wdt.c > index 35725e2..2365828 100644 > --- a/drivers/watchdog/bcm47xx_wdt.c > +++ b/drivers/watchdog/bcm47xx_wdt.c > @@ -97,7 +97,7 @@ static int bcm47xx_wdt_restart(struct watchdog_device *wdd, > return 0; > } > > -static struct watchdog_ops bcm47xx_wdt_hard_ops = { > +static const struct watchdog_ops bcm47xx_wdt_hard_ops = { > .owner = THIS_MODULE, > .start = bcm47xx_wdt_hard_start, > .stop = bcm47xx_wdt_hard_stop, > @@ -168,7 +168,7 @@ static int bcm47xx_wdt_soft_set_timeout(struct watchdog_device *wdd, > WDIOF_MAGICCLOSE, > }; > > -static struct watchdog_ops bcm47xx_wdt_soft_ops = { > +static const struct watchdog_ops bcm47xx_wdt_soft_ops = { > .owner = THIS_MODULE, > .start = bcm47xx_wdt_soft_start, > .stop = bcm47xx_wdt_soft_stop, > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html