Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751883AbdFORbn (ORCPT ); Thu, 15 Jun 2017 13:31:43 -0400 Received: from mail-yb0-f177.google.com ([209.85.213.177]:35908 "EHLO mail-yb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbdFORbm (ORCPT ); Thu, 15 Jun 2017 13:31:42 -0400 Date: Thu, 15 Jun 2017 13:31:39 -0400 From: Sean Paul To: Dawid Kurek Cc: Daniel Vetter , Jani Nikula , Sean Paul , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm: Reduce scope of 'state' variable Message-ID: <20170615173139.fawt5c6qyyvr7qwj@art_vandelay> References: <20170615140436.GA9939@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170615140436.GA9939@gmail.com> User-Agent: NeoMutt/20170306-66-6ddb52-dirty (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1121 Lines: 41 On Thu, Jun 15, 2017 at 04:04:36PM +0200, Dawid Kurek wrote: > Smaller scope reduces visibility of variable and makes usage of > uninitialized variable less possible. > > Changes in v2: > - separate declaration and initialization Your patch is missing Signed-off-by tag Sean > --- > drivers/gpu/drm/drm_atomic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index f32506a..5e0d1e1 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -108,9 +108,10 @@ struct drm_atomic_state * > drm_atomic_state_alloc(struct drm_device *dev) > { > struct drm_mode_config *config = &dev->mode_config; > - struct drm_atomic_state *state; > > if (!config->funcs->atomic_state_alloc) { > + struct drm_atomic_state *state; > + > state = kzalloc(sizeof(*state), GFP_KERNEL); > if (!state) > return NULL; > -- > 2.10.0 > > > --- > This email has been checked for viruses by Avast antivirus software. > https://www.avast.com/antivirus -- Sean Paul, Software Engineer, Google / Chromium OS