Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752481AbdFOTOO (ORCPT ); Thu, 15 Jun 2017 15:14:14 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:34773 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071AbdFOTOL (ORCPT ); Thu, 15 Jun 2017 15:14:11 -0400 Subject: Re: [PATCH net-next] net: dsa: assign default CPU port to all ports To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn , Jason Cobham References: <20170615190654.5927-1-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: Date: Thu, 15 Jun 2017 12:14:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170615190654.5927-1-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 681 Lines: 19 On 06/15/2017 12:06 PM, Vivien Didelot wrote: > The current code only assigns the default cpu_dp to all user ports of > the switch to which the CPU port belongs. The user ports of the other > switches of the fabric thus don't have a default CPU port. Which would lead to a crash in dsa_master_netdev() :) > > This patch fixes this by assigning the cpu_dp of all user ports of all > switches of the fabric when the tree is fully parsed. > > Fixes: a29342e73911 ("net: dsa: Associate slave network device with CPU port") > Signed-off-by: Vivien Didelot Thanks for this fix: Reviewed-by: Florian Fainelli -- Florian