Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751869AbdFOUIi (ORCPT ); Thu, 15 Jun 2017 16:08:38 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:8312 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbdFOUIg (ORCPT ); Thu, 15 Jun 2017 16:08:36 -0400 Subject: Re: [PATCH v3 2/2] arm64: dts: add sp804 timer node for Hi3660 To: Leo Yan , Rob Herring , "Mark Rutland" , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Zhangfei Gao , , , , , Guodong Xu , "Haojian Zhuang" References: <1495428748-11153-1-git-send-email-leo.yan@linaro.org> <1495428748-11153-3-git-send-email-leo.yan@linaro.org> From: Wei Xu Message-ID: <5942E77A.8080500@hisilicon.com> Date: Thu, 15 Jun 2017 21:00:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1495428748-11153-3-git-send-email-leo.yan@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.88.226] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.5942E78D.00E4,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 935f1a0247cabac71d9a838b9283f2a4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1735 Lines: 50 Hi Leo, On 2017/5/22 5:52, Leo Yan wrote: > The Hi3660 SoC comes with the sp804 timer in addition to the > architecture timers. These ones are shutdown when reaching a deep idle > states and a backup timer is needed. The sp804 belongs to another power > domain and can fulfill the purpose of replacing temporarily an > architecture timer when the CPU is idle. > > Describe it in the device tree, so it can be enabled at boot time. > > Suggested-by: Daniel Lezcano > Acked-by: Daniel Lezcano > Signed-off-by: Leo Yan > --- > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > index 138fcba..f75c792 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > @@ -173,6 +173,17 @@ > #clock-cells = <1>; > }; > > + dual_timer0: timer@fff14000 { > + compatible = "arm,sp804", "arm,primecell"; > + reg = <0x0 0xfff14000 0x0 0x1000>; > + interrupts = , > + ; > + clocks = <&crg_ctrl HI3660_OSC32K>, > + <&crg_ctrl HI3660_OSC32K>, > + <&crg_ctrl HI3660_OSC32K>; > + clock-names = "timer1", "timer2", "apb_pclk"; > + }; > + > ufs: ufs@ff3b0000 { > compatible = "jedec,ufs-1.1", "hisilicon,hi3660-ufs"; > reg = <0x0 0xff3b0000 0x0 0x1000>, /* 0: HCI standard */ > Since the dts part is not depended on the driver and Guodong has put this into another patch set[1], I will pick up that one. Thanks! [1]: https://lkml.org/lkml/2017/6/14/1049 BR, Wei