Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272AbdFOUug (ORCPT ); Thu, 15 Jun 2017 16:50:36 -0400 Received: from mga07.intel.com ([134.134.136.100]:64788 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbdFOUue (ORCPT ); Thu, 15 Jun 2017 16:50:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,344,1493708400"; d="scan'208";a="868422263" Date: Thu, 15 Jun 2017 13:50:33 -0700 From: Jesse Brandeburg To: "Gustavo A. R. Silva" Cc: Jeff Kirsher , , , , jesse.brandeburg@intel.com Subject: Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment Message-ID: <20170615135033.00001ecf@intel.com> In-Reply-To: <20170615023826.GA8136@embeddedgus> References: <20170615023826.GA8136@embeddedgus> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.30; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 581 Lines: 14 On Wed, 14 Jun 2017 21:38:26 -0500 "Gustavo A. R. Silva" wrote: > Fix incorrect variable assignment. > Based on line 1511: aq_ret = I40_ERR_PARAM; the correct variable to be > used in this instance is aq_ret instead of ret. Also, variable ret is > updated at line 1602 just before return, so assigning a value to this > variable in this code block is useless. > > Addresses-Coverity-ID: 1397693 > Signed-off-by: Gustavo A. R. Silva Thanks for the fix, looks reasonable. Acked-by: Jesse Brandeburg