Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198AbdFOVHp (ORCPT ); Thu, 15 Jun 2017 17:07:45 -0400 Received: from gateway32.websitewelcome.com ([192.185.145.122]:37479 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbdFOVHn (ORCPT ); Thu, 15 Jun 2017 17:07:43 -0400 Date: Thu, 15 Jun 2017 16:07:40 -0500 Message-ID: <20170615160740.Horde.Jp_M9DTPyKHhri-Ff7J7hSX@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Jesse Brandeburg Cc: Jeff Kirsher , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment References: <20170615023826.GA8136@embeddedgus> <20170615135033.00001ecf@intel.com> In-Reply-To: <20170615135033.00001ecf@intel.com> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dLbzQ-0035CD-Ly X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:27856 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 1 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 27 Hi Jesse, Quoting Jesse Brandeburg : > On Wed, 14 Jun 2017 21:38:26 -0500 > "Gustavo A. R. Silva" wrote: > >> Fix incorrect variable assignment. >> Based on line 1511: aq_ret = I40_ERR_PARAM; the correct variable to be >> used in this instance is aq_ret instead of ret. Also, variable ret is >> updated at line 1602 just before return, so assigning a value to this >> variable in this code block is useless. >> >> Addresses-Coverity-ID: 1397693 >> Signed-off-by: Gustavo A. R. Silva > > Thanks for the fix, looks reasonable. > Acked-by: Jesse Brandeburg Absolutely, glad to help. Regards -- Gustavo A. R. Silva