Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751835AbdFOVdM (ORCPT ); Thu, 15 Jun 2017 17:33:12 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:36016 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbdFOVdK (ORCPT ); Thu, 15 Jun 2017 17:33:10 -0400 MIME-Version: 1.0 In-Reply-To: <20170612222511.22030-1-toshi.kani@hpe.com> References: <20170612222511.22030-1-toshi.kani@hpe.com> From: Dan Williams Date: Thu, 15 Jun 2017 14:33:09 -0700 Message-ID: Subject: Re: [PATCH v2] libnvdimm, pmem: Add sysfs notifications to badblocks To: Toshi Kani Cc: Vishal L Verma , Linda Knippers , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 19 On Mon, Jun 12, 2017 at 3:25 PM, Toshi Kani wrote: > Sysfs "badblocks" information may be updated during run-time that: > - MCE, SCI, and sysfs "scrub" may add new bad blocks > - Writes and ioctl() may clear bad blocks > > Add support to send sysfs notifications to sysfs "badblocks" file > under region and pmem directories when their badblocks information > is re-evaluated (but is not necessarily changed) during run-time. > > Signed-off-by: Toshi Kani > Cc: Dan Williams > Cc: Vishal Verma > Cc: Linda Knippers > --- > v2: Send notifications for the clearing case > --- This looks good to me, I've applied it, but I also want to extend the ndctl unit tests to cover this mechanism.