Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbdFOVdg (ORCPT ); Thu, 15 Jun 2017 17:33:36 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35322 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbdFOVdf (ORCPT ); Thu, 15 Jun 2017 17:33:35 -0400 Date: Thu, 15 Jun 2017 17:33:34 -0400 (EDT) Message-Id: <20170615.173334.947301773714825384.davem@davemloft.net> To: garsilva@embeddedor.com Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] atm: solos-pci: remove useless variable assignments From: David Miller In-Reply-To: <20170615195621.GA5600@embeddedgus> References: <20170615195621.GA5600@embeddedgus> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 15 Jun 2017 13:51:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 372 Lines: 11 From: "Gustavo A. R. Silva" Date: Thu, 15 Jun 2017 14:56:21 -0500 > Value assigned to variable _data32_ at lines 1254 and 1257 is > overwritten at line 1260 before it can be used. This makes > such variable assignments useless. > > Addresses-Coverity-ID: 1227049 > Signed-off-by: Gustavo A. R. Silva Applied, thanks.