Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752625AbdFOVoT (ORCPT ); Thu, 15 Jun 2017 17:44:19 -0400 Received: from gateway22.websitewelcome.com ([192.185.46.233]:14741 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752536AbdFOVnt (ORCPT ); Thu, 15 Jun 2017 17:43:49 -0400 Date: Thu, 15 Jun 2017 16:43:36 -0500 Message-ID: <20170615164336.Horde.41f0yf4qsGt84ZI8i8R-i9B@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: David Miller Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] atm: solos-pci: remove useless variable assignments References: <20170615195621.GA5600@embeddedgus> <20170615.173334.947301773714825384.davem@davemloft.net> In-Reply-To: <20170615.173334.947301773714825384.davem@davemloft.net> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dLcYC-003bgw-Ho X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:16351 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 503 Lines: 24 Hi David, Quoting David Miller : > From: "Gustavo A. R. Silva" > Date: Thu, 15 Jun 2017 14:56:21 -0500 > >> Value assigned to variable _data32_ at lines 1254 and 1257 is >> overwritten at line 1260 before it can be used. This makes >> such variable assignments useless. >> >> Addresses-Coverity-ID: 1227049 >> Signed-off-by: Gustavo A. R. Silva > > Applied, thanks. Absolutely, glad to help. Regards -- Gustavo A. R. Silva