Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbdFOWHh (ORCPT ); Thu, 15 Jun 2017 18:07:37 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:55322 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750820AbdFOWHf (ORCPT ); Thu, 15 Jun 2017 18:07:35 -0400 Date: Fri, 16 Jun 2017 01:07:00 +0300 From: Sakari Ailus To: Pavel Machek Cc: Laurent Pinchart , mchehab@kernel.org, kernel list , ivo.g.dimitrov.75@gmail.com, sre@kernel.org, pali.rohar@gmail.com, linux-media@vger.kernel.org Subject: Re: v4l2-fwnode: status, plans for merge, any branch to merge against? Message-ID: <20170615220659.GG12407@valkosipuli.retiisi.org.uk> References: <20170302112401.GF3220@valkosipuli.retiisi.org.uk> <20170302123848.GA28230@amd> <20170304130318.GU3220@valkosipuli.retiisi.org.uk> <20170306072323.GA23509@amd> <20170310225418.GJ3220@valkosipuli.retiisi.org.uk> <20170613122240.GA2803@amd> <20170613124748.GD12407@valkosipuli.retiisi.org.uk> <20170613210900.GA31456@amd> <20170614110634.GP12407@valkosipuli.retiisi.org.uk> <20170614194128.GA5669@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170614194128.GA5669@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 24 On Wed, Jun 14, 2017 at 09:41:29PM +0200, Pavel Machek wrote: > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index 4ca3fc9..b80debf 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -2026,7 +2026,7 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode, > > isd->bus = buscfg; > > - ret = v4l2_fwnode_endpoint_parse(fwn, vep); > + ret = v4l2_fwnode_endpoint_parse(fwnode, &vep); > if (ret) > return ret; I just pushed the fix there. Btw. I think we should probably drop the change allocating the sub-device configuration separately. It's better to associate the lens, flash and eeprom (where it exists) to the sensor than to the CSI-2 receiver. In that case there are no async sub-devices without bus configuration. -- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk