Subject: Re: [PATCH] drm: atmel-hlcdc: sama5d4 does not have overlay2
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
        Peter Rosin <peda@lysator.liu.se>,
        Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org
References: <1497518653-2788-1-git-send-email-peda@lysator.liu.se>
 <20170615113748.1c98f898@bbrezillon>
From: Peter Rosin <peda@axentia.se>
Organization: Axentia Technologies AB
Message-ID: <08a95adb-90af-1439-73be-4f992d433d1d@axentia.se>
Date: Fri, 16 Jun 2017 00:40:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170615113748.1c98f898@bbrezillon>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2017 22:40:12.9341 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0202MB2547
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1915
Lines: 68

On 2017-06-15 11:37, Boris Brezillon wrote:
> On Thu, 15 Jun 2017 11:24:13 +0200
> Peter Rosin <peda@lysator.liu.se> wrote:
> 
>> From: Peter Rosin <peda@axentia.se>
>>
>> Remove the layer.
> 
> Duh. It was present in the datasheet I had. Just downloaded last
> version of the datasheet and it's no longer there.

Heh.

> Nicolas, there's still a reference to OVR2 in the block diagram
> (Section "31.3 Block Diagram"), can ask fix that (or ask someone who
> can).

Also, on page 2 (the Features chapter under peripherals) there's:

   "LCD TFT Controller with 4 overlays..."

I think it should be three?

Cheers,
peda

>>
>> Fixes: 5b9fb5e6c6c7 ("drm: atmel-hlcdc: add support for sama5d4 SoCs")
>> Signed-off-by: Peter Rosin <peda@axentia.se>
>> ---
>>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 20 +-------------------
>>  1 file changed, 1 insertion(+), 19 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
>> index 30dbffd..888524a 100644
>> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
>> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
>> @@ -295,28 +295,10 @@ static const struct atmel_hlcdc_layer_desc atmel_hlcdc_sama5d4_layers[] = {
>>  		},
>>  	},
>>  	{
>> -		.name = "overlay2",
>> -		.formats = &atmel_hlcdc_plane_rgb_formats,
>> -		.regs_offset = 0x240,
>> -		.id = 2,
>> -		.type = ATMEL_HLCDC_OVERLAY_LAYER,
>> -		.cfgs_offset = 0x2c,
>> -		.layout = {
>> -			.pos = 2,
>> -			.size = 3,
>> -			.xstride = { 4 },
>> -			.pstride = { 5 },
>> -			.default_color = 6,
>> -			.chroma_key = 7,
>> -			.chroma_key_mask = 8,
>> -			.general_config = 9,
>> -		},
>> -	},
>> -	{
>>  		.name = "high-end-overlay",
>>  		.formats = &atmel_hlcdc_plane_rgb_and_yuv_formats,
>>  		.regs_offset = 0x340,
>> -		.id = 3,
>> +		.id = 2,
>>  		.type = ATMEL_HLCDC_OVERLAY_LAYER,
>>  		.cfgs_offset = 0x4c,
>>  		.layout = {
>