MIME-Version: 1.0
In-Reply-To: <5942E633.9040908@hisilicon.com>
References: <20170608220841.26531-1-guodong.xu@linaro.org> <20170608220841.26531-8-guodong.xu@linaro.org>
 <5942E633.9040908@hisilicon.com>
From: Guodong Xu <guodong.xu@linaro.org>
Date: Fri, 16 Jun 2017 11:47:11 +0800
Message-ID: <CAFGCpxx=vPP-Wcby+kz63gB5rp+CHrwSPNYAfyv15nmy_Tvq_Q@mail.gmail.com>
Subject: Re: [PATCH v6 7/8] arm64: dts: hikey960: add device node for pmic and regulators
To: Wei Xu <xuwei5@hisilicon.com>
Cc: Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, Kevin Hilman <khilman@baylibre.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Gregory CLEMENT <gregory.clement@free-electrons.com>,
        horms+renesas@verge.net.au, Olof Johansson <olof@lixom.net>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Riku Voipio <riku.voipio@linaro.org>,
        Thierry Reding <treding@nvidia.com>,
        Krzysztof Kozlowski <krzk@kernel.org>, Eric Anholt <eric@anholt.net>,
        damm+renesas@opensource.se, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        "hw Wang(Xiaoyin)" <hw.wangxiaoyin@hisilicon.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3392
Lines: 86

Thanks, Wei.

On Fri, Jun 16, 2017 at 3:55 AM, Wei Xu <xuwei5@hisilicon.com> wrote:
> Hi Guodong,
>
> On 2017/6/8 23:08, Guodong Xu wrote:
>> From: Wang Xiaoyin <hw.wangxiaoyin@hisilicon.com>
>>
>> add device node for hi6421 pmic core and hi6421v530
>> voltage regulator,include LDO(1,3,9,11,15,16)
>>
>> Signed-off-by: Wang Xiaoyin <hw.wangxiaoyin@hisilicon.com>
>> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 46 +++++++++++++++++++++++
>>  1 file changed, 46 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> index ca448f0..e579333 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> @@ -97,6 +97,52 @@
>>                       default-state = "off";
>>               };
>>       };
>> +
>> +     pmic: pmic@fff34000 {
>> +             compatible = "hisilicon,hi6421v530-pmic";
>> +             reg = <0x0 0xfff34000 0x0 0x1000>;
>> +             interrupt-controller;
>> +             #interrupt-cells = <2>;
>> +
>> +             regulators {
>> +                     ldo3: LDO3 { /* HDMI */
>> +                             regulator-name = "VOUT3_1V85";
>> +                             regulator-min-microvolt = <1800000>;
>> +                             regulator-max-microvolt = <2200000>;
>> +                             regulator-enable-ramp-delay = <120>;
>> +                     };
>> +
>> +                     ldo9: LDO9 { /* SDCARD I/O */
>> +                             regulator-name = "VOUT9_1V8_2V95";
>> +                             regulator-min-microvolt = <1750000>;
>> +                             regulator-max-microvolt = <3300000>;
>> +                             regulator-enable-ramp-delay = <240>;
>> +                     };
>> +
>> +                     ldo11: LDO11 { /* Low Speed Connector */
>> +                             regulator-name = "VOUT11_1V8_2V95";
>> +                             regulator-min-microvolt = <1750000>;
>> +                             regulator-max-microvolt = <3300000>;
>> +                             regulator-enable-ramp-delay = <240>;
>> +                     };
>> +
>> +                     ldo15: LDO15 { /* UFS VCC */
>> +                             regulator-name = "VOUT15_3V0";
>> +                             regulator-min-microvolt = <1750000>;
>> +                             regulator-max-microvolt = <3000000>;
>> +                             regulator-boot-on;
>> +                             regulator-always-on;
>> +                             regulator-enable-ramp-delay = <120>;
>> +                     };
>> +
>> +                     ldo16: LDO16 { /* SD VDD */
>> +                             regulator-name = "VOUT16_2V95";
>> +                             regulator-min-microvolt = <1750000>;
>> +                             regulator-max-microvolt = <3000000>;
>> +                             regulator-enable-ramp-delay = <360>;
>> +                     };
>> +             };
>> +     };
>>  };
>>
>>  &i2c0 {
>>
>
> Since you put the dts part into another patch set[1] and the driver part has been applied.
> I will pick up [1].
> Thanks!
>
> [1]: https://lkml.org/lkml/2017/6/14/1052
>
> BR,
> Wei
>