Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbdFPGCw (ORCPT ); Fri, 16 Jun 2017 02:02:52 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57822 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751144AbdFPGCv (ORCPT ); Fri, 16 Jun 2017 02:02:51 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BD14460C6D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH] bridge: Fix panel-bridge error return on !panel. To: Eric Anholt , dri-devel@lists.freedesktop.org, Andrzej Hajda , Laurent Pinchart Cc: linux-kernel@vger.kernel.org References: <20170615175423.17954-1-eric@anholt.net> From: Archit Taneja Message-ID: <836e590e-909a-3463-1d96-209040e1c317@codeaurora.org> Date: Fri, 16 Jun 2017 11:32:46 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170615175423.17954-1-eric@anholt.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 909 Lines: 33 On 06/15/2017 11:24 PM, Eric Anholt wrote: > ERR_PTR() needs a negative errno argument. Thanks, I'll queue it to drm-misc-next-fixes once it's opened. Archit > > Signed-off-by: Eric Anholt > --- > drivers/gpu/drm/bridge/panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index 99f9a4beb859..67fe19e5a9c6 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -161,7 +161,7 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel, > int ret; > > if (!panel) > - return ERR_PTR(EINVAL); > + return ERR_PTR(-EINVAL); > > panel_bridge = devm_kzalloc(panel->dev, sizeof(*panel_bridge), > GFP_KERNEL); > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project