Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbdFPHUX (ORCPT ); Fri, 16 Jun 2017 03:20:23 -0400 Received: from 2.mo68.mail-out.ovh.net ([46.105.52.162]:45124 "EHLO 2.mo68.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751879AbdFPHUV (ORCPT ); Fri, 16 Jun 2017 03:20:21 -0400 Subject: Re: [PATCH V2 0/5] phy: bcm-ns-usb3: add MDIO driver To: Kishon Vijay Abraham I , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20170511132925.14564-1-zajec5@gmail.com> <20170608200428.9187-1-zajec5@gmail.com> Cc: Yendapally Reddy Dhananjaya Reddy , Jon Mason , Florian Fainelli , linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: <30100fc8-7538-fd30-0a6a-665019b38c38@milecki.pl> Date: Fri, 16 Jun 2017 09:14:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 9612651932713848343 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeljedrjeekgdduvdefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 29 On 06/16/2017 08:36 AM, Kishon Vijay Abraham I wrote: > On Friday 09 June 2017 01:34 AM, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> As explained in the commit 9200c6f177638 ("Revert "phy: Add USB3 PHY support >> for Broadcom NSP SoC"") this module should be modified to use MDIO bus as >> this is how PHY is really attached. >> >> This should allow reusing this driver on NSP and any other platform with >> MDIO bus and this particular PHY. > > can you run checkpatch and fix all warnings in this series? I always check my patches before sending. For this set the only warning I get is: WARNING: line over 80 characters #117: FILE: drivers/phy/broadcom/phy-bcm-ns-usb3.c:224: + usecs_to_jiffies(BCM_NS_USB3_MII_MNG_TIMEOUT_US)); I've problem finding a nice way of fixing this. 1) I can't break the line between arguments as there is only 1 argument 2) I shouldn't use small indention as it would misalign this line 3) Using tmp var for BCM_NS_USB3_MII_MNG_TIMEOUT_US sounds a bit pointless According to the coding-style.rst having 80+ chars lines is acceptable if it "significantly increases readability and does not hide information". Maybe we can just live with this single line like that? Isn't this a bit bike shedding in this case?