Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752718AbdFPHiy (ORCPT ); Fri, 16 Jun 2017 03:38:54 -0400 Received: from rcdn-iport-7.cisco.com ([173.37.86.78]:56044 "EHLO rcdn-iport-7.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447AbdFPHiw (ORCPT ); Fri, 16 Jun 2017 03:38:52 -0400 X-Greylist: delayed 628 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Jun 2017 03:38:52 EDT X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ATAQBeh0NZ/5RdJa1dGgEBAQECAQEBA?= =?us-ascii?q?QgBAQEBg1iBbweDZIoYqAGCEYYkAhqCTT8YAQIBAQEBAQEBayiFGQYjEUUQAgE?= =?us-ascii?q?IGgImAgICMBUQAgQBDQWKLKlLgiaLRAEBAQEBAQEBAQEBAQEBAQEBAQEBAR2BC?= =?us-ascii?q?4VYgguCeIQ5MReCezCCMQEElxaHQQKTWJIOSJQ7AR84gQp0FVsBhnx2hxCBMoE?= =?us-ascii?q?NAQEB?= X-IronPort-AV: E=Sophos;i="5.39,346,1493683200"; d="scan'208";a="256722403" From: "Mats Randgaard (matrandg)" To: "Gustavo A. R. Silva" , Mauro Carvalho Chehab CC: "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] i2c: tc358743: remove useless variable assignment in tc358743_isr Thread-Topic: [PATCH] i2c: tc358743: remove useless variable assignment in tc358743_isr Thread-Index: AQHS5fdUR6geRn6uHk+PWbpAiJDaI6InfOeA Date: Fri, 16 Jun 2017 07:28:20 +0000 Message-ID: References: <20170615164914.GA23292@embeddedgus> In-Reply-To: <20170615164914.GA23292@embeddedgus> Accept-Language: en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/f.1d.0.161209 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.55.176.218] Content-Type: text/plain; charset="utf-8" Content-ID: <78A9EAD7276D144283B73B54F24F94E2@emea.cisco.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5G7cxLO015699 Content-Length: 1080 Lines: 40 Thanks! You could remove intstatus &= ~MASK_HDMI_INT; in line 1289 as well. Regards, Mats Randgaard On 15/06/2017, 18:49, "Gustavo A. R. Silva" wrote: Remove useless variable assignment in function tc358743_isr(). The value stored in variable _intstatus_ at line 1299 is overwritten at line 1302, just before it can be used. Addresses-Coverity-ID: 1397678 Signed-off-by: Gustavo A. R. Silva --- drivers/media/i2c/tc358743.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 3251cba..e8b23f3 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1296,7 +1296,6 @@ static int tc358743_isr(struct v4l2_subdev *sd, u32 status, bool *handled) tc358743_csi_err_int_handler(sd, handled); i2c_wr16(sd, INTSTATUS, MASK_CSI_INT); - intstatus &= ~MASK_CSI_INT; } intstatus = i2c_rd16(sd, INTSTATUS); -- 2.5.0