Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770AbdFPHwv (ORCPT ); Fri, 16 Jun 2017 03:52:51 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:44973 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375AbdFPHwt (ORCPT ); Fri, 16 Jun 2017 03:52:49 -0400 Subject: Re: [PATCH V2 0/5] phy: bcm-ns-usb3: add MDIO driver To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20170511132925.14564-1-zajec5@gmail.com> <20170608200428.9187-1-zajec5@gmail.com> <30100fc8-7538-fd30-0a6a-665019b38c38@milecki.pl> CC: Yendapally Reddy Dhananjaya Reddy , Jon Mason , Florian Fainelli , , , , From: Kishon Vijay Abraham I Message-ID: <68b4f1ed-fc3b-77a0-fb6e-f024814a4a66@ti.com> Date: Fri, 16 Jun 2017 13:22:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <30100fc8-7538-fd30-0a6a-665019b38c38@milecki.pl> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1502 Lines: 38 Hi, On Friday 16 June 2017 12:44 PM, Rafał Miłecki wrote: > On 06/16/2017 08:36 AM, Kishon Vijay Abraham I wrote: >> On Friday 09 June 2017 01:34 AM, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> As explained in the commit 9200c6f177638 ("Revert "phy: Add USB3 PHY support >>> for Broadcom NSP SoC"") this module should be modified to use MDIO bus as >>> this is how PHY is really attached. >>> >>> This should allow reusing this driver on NSP and any other platform with >>> MDIO bus and this particular PHY. >> >> can you run checkpatch and fix all warnings in this series? > > I always check my patches before sending. For this set the only warning I > get is: > > WARNING: line over 80 characters > #117: FILE: drivers/phy/broadcom/phy-bcm-ns-usb3.c:224: > + > usecs_to_jiffies(BCM_NS_USB3_MII_MNG_TIMEOUT_US)); > > I've problem finding a nice way of fixing this. > 1) I can't break the line between arguments as there is only 1 argument > 2) I shouldn't use small indention as it would misalign this line > 3) Using tmp var for BCM_NS_USB3_MII_MNG_TIMEOUT_US sounds a bit pointless > > According to the coding-style.rst having 80+ chars lines is acceptable if it > "significantly increases readability and does not hide information". Maybe > we can just live with this single line like that? Isn't this a bit bike > shedding in this case? Sure, just wanted to make sure we didn't overlook checkpatch warnings. Thanks Kishon