Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753287AbdFPJNp (ORCPT ); Fri, 16 Jun 2017 05:13:45 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:37192 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753202AbdFPJNm (ORCPT ); Fri, 16 Jun 2017 05:13:42 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170601200820.22396-1-ralph.sennhauser@gmail.com> From: Linus Walleij Date: Fri, 16 Jun 2017 11:13:40 +0200 Message-ID: Subject: Re: [PATCH] gpio: mvebu: change compatible string for PWM support To: Richard Genoud Cc: Ralph Sennhauser , "linux-gpio@vger.kernel.org" , Thierry Reding , Alexandre Courbot , Rob Herring , Mark Rutland , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-pwm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1121 Lines: 27 On Fri, Jun 9, 2017 at 9:45 AM, Richard Genoud wrote: > 2017-06-09 9:42 GMT+02:00 Linus Walleij : >> On Thu, Jun 1, 2017 at 10:08 PM, Ralph Sennhauser >> wrote: >> >>> As it turns out more than just Armada 370 and XP support using GPIO >>> lines as PWM lines. For example the Armada 38x family has the same >>> hardware support. As such "marvell,armada-370-xp-gpio" for the >>> compatible string is a misnomer. >>> >>> Change the compatible string to "marvell,armada-370-gpio" before the >>> driver makes it out of the -rc stage. This also follows the practice of >>> using only the first device family supported as part of the name. >>> >>> Also update the documentation and comments in the code accordingly. >>> >>> Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support") >>> Signed-off-by: Ralph Sennhauser >> >> Patch applied for next with the tags. > You mean for fixes right ? > The goal was to correct "marvell,armada-370-xp-gpio" before 4.12 is out. OK I moved it to fixes. Yours, Linus Walleij