Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753325AbdFPJSm (ORCPT ); Fri, 16 Jun 2017 05:18:42 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:35567 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753172AbdFPJSk (ORCPT ); Fri, 16 Jun 2017 05:18:40 -0400 MIME-Version: 1.0 In-Reply-To: <9a098130daa8daeef89fd6c1e80d982699d5c175.1497281623.git-series.gregory.clement@free-electrons.com> References: <9a098130daa8daeef89fd6c1e80d982699d5c175.1497281623.git-series.gregory.clement@free-electrons.com> From: Linus Walleij Date: Fri, 16 Jun 2017 11:18:38 +0200 Message-ID: Subject: Re: [PATCH v3 1/9] gpio: mvebu: fix regmap_update_bits usage To: Gregory CLEMENT Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" , Rob Herring , "devicetree@vger.kernel.org" , Russell King , Nadav Haklai , Kostya Porotchkin , Neta Zur Hershkovits , Marcin Wojtas , Omri Itach , Shadi Ammouri , Chris Packham , Ralph Sennhauser Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 20 On Mon, Jun 12, 2017 at 5:34 PM, Gregory CLEMENT wrote: > In some place in the driver regmap_update_bits was misused. Indeed the > last argument is not the value of the bit (or group of bits) itself but > the mask value inside the register. > > So when setting the bit N, then the value must be BIT(N) and not 1. > > CC: Chris Packham > CC: Ralph Sennhauser > Reviewed-by: Thomas Petazzoni > Tested-by: Ralph Sennhauser > Tested-by: Chris Packham > Signed-off-by: Gregory CLEMENT Already applied this patch, sorry for missing the resend in the series. Yours, Linus Walleij