Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753290AbdFPJfV (ORCPT ); Fri, 16 Jun 2017 05:35:21 -0400 Received: from gloria.sntech.de ([95.129.55.99]:43744 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753220AbdFPJfT (ORCPT ); Fri, 16 Jun 2017 05:35:19 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Frank Wang Cc: Finley Xiao , gregkh@linuxfoundation.org, robh+dt@kernel.org, ulf.hansson@linaro.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, charles.chen@rock-chips.com, kevan.lan@rock-chips.com, huangtao@rock-chips.com, david.wu@rock-chips.com, shawn.lin@rock-chips.com, wmc@rock-chips.com Subject: Re: [PATCH 6/6] ARM: dts: rockchip: add efuse device node for rk3228 Date: Fri, 16 Jun 2017 11:35:12 +0200 Message-ID: <2264017.eLNdPIXHd9@diego> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: References: <1497510980-23207-1-git-send-email-frank.wang@rock-chips.com> <2537345.MJmYY2BcSn@phil> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2026 Lines: 79 Am Freitag, 16. Juni 2017, 17:24:23 CEST schrieb Frank Wang: > Hi Heiko, > > On 2017/6/15 23:10, Heiko Stuebner wrote: > > Hi Frank, > > > > Am Donnerstag, 15. Juni 2017, 15:23:16 CEST schrieb Frank Wang: > >> From: Finley Xiao > >> > >> Add a efuse node in the device tree for the rk3228 SoC. > >> > >> Signed-off-by: Finley Xiao > >> --- > >> > >> arch/arm/boot/dts/rk322x.dtsi | 17 +++++++++++++++++ > >> 1 file changed, 17 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/rk322x.dtsi > >> b/arch/arm/boot/dts/rk322x.dtsi > >> index c2a78f4..dad195e 100644 > >> --- a/arch/arm/boot/dts/rk322x.dtsi > >> +++ b/arch/arm/boot/dts/rk322x.dtsi > >> @@ -314,6 +314,23 @@ > >> > >> status = "disabled"; > >> > >> }; > >> > >> + efuse: efuse@11040000 { > >> + compatible = "rockchip,rk322x-efuse"; > > > > was this binding included already? Simply because compatibles should > > not contain placeholders, so rockchip,rk3228-efuse please - same for > > the driver side. > > Actually, I always remember it should be without placeholders from the > first time you commented :-) > but I saw that the binding and driver (rockchip,rk322x-efuse) have > already been applied, so I send this one keep the same with driver side. > Shall I resend a new patch to correct both of them to > 'rockchip,rk3228-efuse' ? Yes please :-) . As it was probably applied for 4.13, changing the compatible shouldn't be a problem. Thanks Heiko > > > BR. > Frank > > > Heiko > > > >> + reg = <0x11040000 0x20>; > >> + #address-cells = <1>; > >> + #size-cells = <1>; > >> + clocks = <&cru PCLK_EFUSE_256>; > >> + clock-names = "pclk_efuse"; > >> + > >> + /* Data cells */ > >> + efuse_id: id@7 { > >> + reg = <0x7 0x10>; > >> + }; > >> + cpu_leakage: cpu_leakage@17 { > >> + reg = <0x17 0x1>; > >> + }; > >> + }; > >> + > >> > >> i2c0: i2c@11050000 { > >> > >> compatible = "rockchip,rk3228-i2c"; > >> reg = <0x11050000 0x1000>;