Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753435AbdFPJtS (ORCPT ); Fri, 16 Jun 2017 05:49:18 -0400 Received: from ozlabs.org ([103.22.144.67]:50841 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753060AbdFPJtR (ORCPT ); Fri, 16 Jun 2017 05:49:17 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: a093c92dc7f96a15de98ec8cfe38e6f7610a5969 In-Reply-To: <20170614030125.45899-1-aik@ozlabs.ru> To: Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: Alexey Kardashevskiy , linux-kernel@vger.kernel.org, Peter Zijlstra , Paul Mackerras Subject: Re: [kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path Message-Id: <3wpwZ33lkXz9sCX@ozlabs.org> Date: Fri, 16 Jun 2017 19:49:14 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 657 Lines: 15 On Wed, 2017-06-14 at 03:01:25 UTC, Alexey Kardashevskiy wrote: > When trapped on WARN_ON(), report_bug() is expected to return > BUG_TRAP_TYPE_WARN so the caller could increment NIP by 4 and continue. > The __builtin_constant_p() path of the PPC's WARN_ON() calls (indirectly) > __WARN_FLAGS() which has BUGFLAG_WARNING set, however the other branch > does not which makes report_bug() report a bug rather than a warning. > > Fixes: f26dee15103f ("debug: Avoid setting BUGFLAG_WARNING twice") > Signed-off-by: Alexey Kardashevskiy Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/a093c92dc7f96a15de98ec8cfe38e6 cheers