Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752976AbdFPK2t (ORCPT ); Fri, 16 Jun 2017 06:28:49 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33582 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752923AbdFPK2p (ORCPT ); Fri, 16 Jun 2017 06:28:45 -0400 Subject: Re: [PATCH] mtd: spi-nor: cqspi: make of_device_ids const To: Arvind Yadav , cyrille.pitchen@wedev4u.fr, dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, richard@nod.at References: Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: <4f604ebc-69a7-4e35-d682-cc4fa9e76c82@gmail.com> Date: Fri, 16 Jun 2017 12:27:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 33 On 06/16/2017 11:35 AM, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Works for me Reviewed-by: Marek Vasut > --- > drivers/mtd/spi-nor/cadence-quadspi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c > index 9f8102d..1a25637 100644 > --- a/drivers/mtd/spi-nor/cadence-quadspi.c > +++ b/drivers/mtd/spi-nor/cadence-quadspi.c > @@ -1277,7 +1277,7 @@ static int cqspi_resume(struct device *dev) > #define CQSPI_DEV_PM_OPS NULL > #endif > > -static struct of_device_id const cqspi_dt_ids[] = { > +static const struct of_device_id const cqspi_dt_ids[] = { > {.compatible = "cdns,qspi-nor",}, > { /* end of table */ } > }; > -- Best regards, Marek Vasut