Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753121AbdFPLpO (ORCPT ); Fri, 16 Jun 2017 07:45:14 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:35659 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752647AbdFPLpM (ORCPT ); Fri, 16 Jun 2017 07:45:12 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170614211556.2062728-1-arnd@arndb.de> <20170614211556.2062728-12-arnd@arndb.de> From: Dmitry Vyukov Date: Fri, 16 Jun 2017 13:44:50 +0200 Message-ID: Subject: Re: [PATCH v2 11/11] kasan: rework Kconfig settings To: Arnd Bergmann Cc: Andrew Morton , kasan-dev , Alexander Potapenko , Andrey Ryabinin , netdev , LKML , Arend van Spriel , Masahiro Yamada , Michal Marek , Kees Cook , Ingo Molnar , "David S. Miller" , "open list:KERNEL BUILD + fi..." Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 30 On Fri, Jun 16, 2017 at 1:42 PM, Arnd Bergmann wrote: >>> diff --git a/lib/Kconfig.kmemcheck b/lib/Kconfig.kmemcheck >>> index 846e039a86b4..58b9f3f81dc8 100644 >>> --- a/lib/Kconfig.kmemcheck >>> +++ b/lib/Kconfig.kmemcheck >>> @@ -7,6 +7,7 @@ menuconfig KMEMCHECK >>> bool "kmemcheck: trap use of uninitialized memory" >>> depends on DEBUG_KERNEL >>> depends on !X86_USE_3DNOW >>> + depends on !KASAN_EXTRA >> >> >> KASAN is not meant to work with KMEMCHECK. I am not sure if it even >> works, and it's definitely unmaintained. Even if it works now, I am >> not sure what could be the intention of somebody running that >> combination. >> So I think we should do: depends on !KASAN >> Will it make things simper for you? > > I don't think it will change anything for me, other than having to respin the > patch series or adding a patch on top. > > I have just checked that KMEMCHECK is already disabled in allmodconfig, > and all but one of the warnings I address in the series show up in > allmodconfig too. Ack. We can disable it if/when KASAN+KMEMCHECK combination requires any additional work, or causes user confusion.