Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753084AbdFPLsc (ORCPT ); Fri, 16 Jun 2017 07:48:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:53465 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752956AbdFPLsc (ORCPT ); Fri, 16 Jun 2017 07:48:32 -0400 Date: Fri, 16 Jun 2017 13:48:30 +0200 From: Johannes Thumshirn To: Arvind Yadav Cc: jthumshirn@suse.de, axboe@fb.com, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: swim3: make of_device_ids const. Message-ID: <20170616114830.GB25147@linux-x5ow.site> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1007 Lines: 25 On Fri, Jun 16, 2017 at 03:24:39PM +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 8908 1096 624 10628 2984 drivers/block/swim3.o > > File size after constify swim3_match: > text data bss dec hex filename > 9708 296 624 10628 2984 drivers/block/swim3.o > > Signed-off-by: Arvind Yadav > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850