Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753503AbdFPL6S (ORCPT ); Fri, 16 Jun 2017 07:58:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55468 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753364AbdFPL6Q (ORCPT ); Fri, 16 Jun 2017 07:58:16 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3C7F530AF52 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jan.kratochvil@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3C7F530AF52 Date: Fri, 16 Jun 2017 13:57:44 +0200 From: Jan Kratochvil To: Milian Wolff Cc: Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , David Ahern , Namhyung Kim , Peter Zijlstra , Yao Jin , Jiri Olsa Subject: Re: perf report: fix off-by-one for non-activation frames Message-ID: <20170616115744.GA14948@host1.jankratochvil.net> References: <20170515150444.6841-1-milian.wolff@kdab.com> <20170616061456.GA2472@host1.jankratochvil.net> <5576772.scvU8aRrkq@agathebauer> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5576772.scvU8aRrkq@agathebauer> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 16 Jun 2017 11:58:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 32 On Fri, 16 Jun 2017 13:51:37 +0200, Milian Wolff wrote: > > perf-4.12.0-0.rc5.git0.1.fc27.x86_64 > > 39e32e gdb_main (/usr/libexec/gdb) > > 10b6fa main (/usr/libexec/gdb) > > 0x000055555565f6f6 <+54>: callq 0x5555558f17a0 > 0x000055555565f6fb <+59>: mov 0x18(%rsp),%rcx [...] > Excuse me, but I'm having trouble following you. The non-GDB backtraces you > are pasting do not show srcline information. So what exactly is broken? There is broken that perf now reports address 10b6fa (corresponding to relocated address 0x000055555565f6fa) but there is no instruction on address 0x000055555565f6fa. If you 'objdump -d' it you cannot find any instruction on adress 0x000055555565f6fa (or on address 0x10b6fa). There is instruction on address 0x000055555565f6fb. > Maybe paste the perf output you get now and highlight what you'd expect > instead? Actual: 39e32e gdb_main (/usr/libexec/gdb) 10b6fa main (/usr/libexec/gdb) Expected: 39e32f gdb_main (/usr/libexec/gdb) 10b6fb main (/usr/libexec/gdb) I agree perf needs to calculate with 39e32e and 10b6fa. But it should display to user 39e32f and 10b6fb. Jan