Subject: Re: [RFC] ubsan: signed integer overflow in scsi_partsize
To: Alice Ferrazzi <alicef@gentoo.org>, <jejb@linux.vnet.ibm.com>,
        <martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20170616132932.GG20222@alitoo>
From: Bart Van Assche <bart.vanassche@wdc.com>
Message-ID: <8a48d772-9860-b74f-25fc-57bda30bd663@wdc.com>
Date: Fri, 16 Jun 2017 08:01:27 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <20170616132932.GG20222@alitoo>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
WDCIPOUTBOUND: EOP-TRUE
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2017 15:01:33.7725
 (UTC)
X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR04MB544
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 447
Lines: 13

On 06/16/17 06:29, Alice Ferrazzi wrote:
> A Gentoo user reported a USBAN signed integer overflow in scsicam.c
> Shall we change something?

Hello Alice,

Some of the code in drivers/scsi/scsicam.c duplicates code in
block/partitions/msdos.c and block/genhd.c. I think patches that remove
the partition table parsing code from drivers/scsi/scsicam.c and that
use the generic partition table parsing code instead would be more than
welcome.

Bart.