Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752706AbdFPQCK (ORCPT ); Fri, 16 Jun 2017 12:02:10 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60766 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751012AbdFPQCH (ORCPT ); Fri, 16 Jun 2017 12:02:07 -0400 Date: Fri, 16 Jun 2017 12:02:02 -0400 (EDT) Message-Id: <20170616.120202.12666969526527584.davem@davemloft.net> To: yanhaishuang@cmss.chinamobile.com Cc: edumazet@google.com, pshelar@ovn.org, ast@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv From: David Miller In-Reply-To: <1497493770-13000-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1497493770-13000-1-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 16 Jun 2017 08:20:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 514 Lines: 13 From: Haishuang Yan Date: Thu, 15 Jun 2017 10:29:29 +0800 > When ip_tunnel_rcv fails, the tun_dst won't be freed, so call > dst_release to free it in error code path. > > Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") > Acked-by: Eric Dumazet > Acked-by: Pravin B Shelar > Tested-by: Zhang Shengju > Signed-off-by: Haishuang Yan Applied.