Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbdFPRpM (ORCPT ); Fri, 16 Jun 2017 13:45:12 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:36747 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639AbdFPRpL (ORCPT ); Fri, 16 Jun 2017 13:45:11 -0400 Subject: Re: [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC_SERIO To: "Maciej W. Rozycki" Cc: linux-mips@linux-mips.org, msalter@redhat.com, dmitry.torokhov@gmail.com, Ralf Baechle , open list References: <20170605171033.15008-1-f.fainelli@gmail.com> From: Florian Fainelli Message-ID: <1ccd3748-9b52-2b23-f686-df86d8be050d@gmail.com> Date: Fri, 16 Jun 2017 10:45:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 22 On 06/15/2017 06:56 PM, Maciej W. Rozycki wrote: > On Mon, 5 Jun 2017, Florian Fainelli wrote: > >> Out of the many MIPS platforms only 3 appear to be actually using an >> I8042 keyboard controller: SGI, JAZZ and LOOGSON64, remove >> ARCH_MIGHT_HAVE_PC_SERIO from the top-level MIPS Kconfig symbol and move >> it down to those platforms that need it. > > How did you determine that? Malta for one not only has an SMSC FDC37M817 > Super I/O Controller featuring an 8042-compatible core, but actual PS/2 > keyboard and mouse connectors as well. I was just grepping for i8042 in platform code to determine that, this came after having SERIO accidentally enabled on my platform (BMIPS_GENERIC) and seeing that it crashed badly and it annoyed the crap out of me that MIPS had ARCH_MIGHT_HAVE_PC_SERIO for platforms that don't need it. Will come up with a v2 that includes malta, any other platforms for which it's not obvious? -- Florian