Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753197AbdFPSYc (ORCPT ); Fri, 16 Jun 2017 14:24:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59264 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753171AbdFPSY3 (ORCPT ); Fri, 16 Jun 2017 14:24:29 -0400 Date: Fri, 16 Jun 2017 11:24:07 -0700 From: Andrew Morton To: Nicholas Piggin Cc: Don Zickus , Babu Moger , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v4 4/5] watchdog: provide watchdog_reconfigure() for arch watchdogs Message-Id: <20170616112407.e150c215209d86d7e8916a47@linux-foundation.org> In-Reply-To: <20170616065715.18390-5-npiggin@gmail.com> References: <20170616065715.18390-1-npiggin@gmail.com> <20170616065715.18390-5-npiggin@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 740 Lines: 25 On Fri, 16 Jun 2017 16:57:14 +1000 Nicholas Piggin wrote: > After reconfiguring watchdog sysctls etc., architecture specific > watchdogs may not get all their parameters updated. > > watchdog_reconfigure() can be implemented to pull the new values > in and set the arch NMI watchdog. > I'll update the title and changelog to say "watchdog_nmi_reconfigure". > --- a/kernel/watchdog.c > +++ b/kernel/watchdog.c > @@ -123,6 +123,11 @@ void __weak watchdog_nmi_disable(unsigned int cpu) > { > } > > +void __weak watchdog_nmi_reconfigure(void) > +{ > +} Can we please get some documentation in here describing what it's for? How arch maintainers might use this? When and why it is called, what it must do? etc.