Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbdFPTnE (ORCPT ); Fri, 16 Jun 2017 15:43:04 -0400 Received: from mail-pg0-f47.google.com ([74.125.83.47]:34549 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbdFPTnD (ORCPT ); Fri, 16 Jun 2017 15:43:03 -0400 Date: Fri, 16 Jun 2017 12:42:58 -0700 From: Benson Leung To: Enric Balletbo i Serra Cc: olof@lixom.net, bleung@chromium.org, linux-kernel@vger.kernel.org, lee.jones@linaro.org, Eric Caruso , Nicolas Boichat Subject: Re: [PATCH RESEND 03/13] mfd: cros_ec: add debugfs, console log file Message-ID: <20170616194258.GA54146@decatoncale.mtv.corp.google.com> References: <20170516161319.13257-1-enric.balletbo@collabora.com> <20170516161319.13257-4-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO" Content-Disposition: inline In-Reply-To: <20170516161319.13257-4-enric.balletbo@collabora.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2331 Lines: 74 --M9NhX3UHpAaciwkO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Enric, I have gotten around to reviewing this series, and hope to get this in ASAP. I found an issue with this commit, but I'll go ahead and fix it myself as I'm creating the immutable branch. No need to respin the series. On Tue, May 16, 2017 at 06:13:09PM +0200, Enric Balletbo i Serra wrote: > +static int ec_read_version_supported(struct cros_ec_dev *ec) > +{ > + struct ec_params_get_cmd_versions_v1 *params; > + struct ec_response_get_cmd_versions *response; > + int ret; > + > + struct cros_ec_command *msg; > + > + msg =3D kzalloc(sizeof(*msg) + max(sizeof(params), sizeof(response)), > + GFP_KERNEL); > + if (!msg) > + return 0; > + > + msg->command =3D EC_CMD_GET_CMD_VERSIONS + ec->cmd_offset; > + msg->outsize =3D sizeof(*params); > + msg->insize =3D sizeof(*response); By my diff, the above two lines were changed from the original CHROMIUM commit, based on Doug's comment here: https://lkml.org/lkml/2017/2/22/630 However, this is an incomplete fix. Instead, we should pick this: https://chromium-review.googlesource.com/#/c/444085/ I'll go ahead and do that. Thanks! Benson --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --M9NhX3UHpAaciwkO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJZRDTCAAoJEB8J9XsKL+ZYxqAP+wWSlyBDe5pgMjWXafrrFLxz 399hpJfUyJ4Em06OaL5nG6K1Xj8Tj6NgRVfltbRNtgIwx7MTN2Ecd7BkRuWiBCTb nRhfGJEbC5Gy4WYGJfSyja2Kk68sfP6BSFHjbzos+6eNFpVLsc/397uuJO9oY6Pm JuhVz+6g8eA/9PWx+j+upExCJX8h6K9jXFkZJ6l5rUxlwEDAniR18fOir47g+gIO hroyjh5wQ3x1JoHzZWsoBvLz/Mvw9N5mD+J9UAHE25ucks2usHVfAC7fhwApqWlv JxlVmpQ2cb4b/vCtUkyJaL3GSfXxVURLuBI7Jv1IijY4ANPakal/nClIzTnJHQJ5 A94fUQtBXkSgQlqQsNBo2ziya9kFUg+4gex9zeqtNdOPxWZJ37YhlrtLm796Jp2U PC+NtcifJBV9HEF1paIlB1g9ZD1IJTcg4Af70imQZU5gEhvYk3IT6kl2xbrI/BJ4 w2EBWfLHEqIrBSC0iz4ydeWef4hcehs0OPKG7ON0LGqRyidRkKoFObd2uzes/DQi s2//jc0NrleyNK08M2jOqqKDzPgEDzsu5rNk9r4C2U7dHGiZf0qh7TYeac1izdkr xPJOwLj0YtysKuhgN5IWN/rAbKh/78VhwqUoGfgDP5JMKfeEtr79zpD7v+d1mISj YbqnuD6CSLwnwpDULl2b =YTzM -----END PGP SIGNATURE----- --M9NhX3UHpAaciwkO--