Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751711AbdFPUTL (ORCPT ); Fri, 16 Jun 2017 16:19:11 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:52013 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbdFPUTK (ORCPT ); Fri, 16 Jun 2017 16:19:10 -0400 Date: Fri, 16 Jun 2017 21:18:56 +0100 From: "Maciej W. Rozycki" To: Florian Fainelli CC: , , , Ralf Baechle , open list Subject: Re: [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC_SERIO In-Reply-To: <1ccd3748-9b52-2b23-f686-df86d8be050d@gmail.com> Message-ID: References: <20170605171033.15008-1-f.fainelli@gmail.com> <1ccd3748-9b52-2b23-f686-df86d8be050d@gmail.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [10.20.78.219] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 23 On Fri, 16 Jun 2017, Florian Fainelli wrote: > > How did you determine that? Malta for one not only has an SMSC FDC37M817 > > Super I/O Controller featuring an 8042-compatible core, but actual PS/2 > > keyboard and mouse connectors as well. > > I was just grepping for i8042 in platform code to determine that, this > came after having SERIO accidentally enabled on my platform > (BMIPS_GENERIC) and seeing that it crashed badly and it annoyed the crap > out of me that MIPS had ARCH_MIGHT_HAVE_PC_SERIO for platforms that > don't need it. > > Will come up with a v2 that includes malta, any other platforms for > which it's not obvious? I don't know offhand, but in principle anything that has PCI and a southbridge (not all PCI platforms have one, e.g. Broadcom SWARM and BigSur are legacy-free) can have an 8042 wired. Ideally probing for 8042 hardware should be done by platform code and the driver's init code would not be called at all if there's no 8042 present, similarly to how e.g. RTC is usually registered. Maciej