Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752120AbdFPU55 (ORCPT ); Fri, 16 Jun 2017 16:57:57 -0400 Received: from mail-pg0-f54.google.com ([74.125.83.54]:35919 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbdFPU5z (ORCPT ); Fri, 16 Jun 2017 16:57:55 -0400 From: Kevin Hilman To: Neil Armstrong Cc: gregkh@linuxfoundation.org, Helmut Klein , linux-serial@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 3/4] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock Organization: BayLibre References: <1497428957-19942-1-git-send-email-narmstrong@baylibre.com> <1497428957-19942-4-git-send-email-narmstrong@baylibre.com> Date: Fri, 16 Jun 2017 13:57:51 -0700 In-Reply-To: <1497428957-19942-4-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Wed, 14 Jun 2017 10:29:16 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1415 Lines: 35 Neil Armstrong writes: > From: Helmut Klein > > This patch switches to the stable UART bindings but also add the correct > gate clock to the non-AO UART nodes for GXBB and GXL SoCs. > > Acked-by: Jerome Brunet > Signed-off-by: Helmut Klein > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 12 +++++------- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 25 +++++++++++++++++++++++++ > arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 25 +++++++++++++++++++++++++ > 3 files changed, 55 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > index 603491d..86a4018 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > @@ -225,7 +225,7 @@ > }; > > uart_A: serial@84c0 { > - compatible = "amlogic,meson-uart"; > + compatible = "amlogic,meson-gx-uart"; IMO, we should keep both compatibles (the more specific one first.) That would allow new DTs to continue to run on older kernels. It would also allow this DT change to be completely independent of the driver changes. Otherwise, if I merge this before the driver change are merged, we'll have a bunch of boards with no more serial console output. Kevin