Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbdFQArB (ORCPT ); Fri, 16 Jun 2017 20:47:01 -0400 Received: from mail-ot0-f181.google.com ([74.125.82.181]:33889 "EHLO mail-ot0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbdFQAq7 (ORCPT ); Fri, 16 Jun 2017 20:46:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170612222511.22030-1-toshi.kani@hpe.com> From: Dan Williams Date: Fri, 16 Jun 2017 17:46:58 -0700 Message-ID: Subject: Re: [PATCH v2] libnvdimm, pmem: Add sysfs notifications to badblocks To: "Kani, Toshimitsu" Cc: "Verma, Vishal L" , "Knippers, Linda" , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1363 Lines: 30 On Fri, Jun 16, 2017 at 5:35 PM, Kani, Toshimitsu wrote: >> On Mon, Jun 12, 2017 at 3:25 PM, Toshi Kani wrote: >> > Sysfs "badblocks" information may be updated during run-time that: >> > - MCE, SCI, and sysfs "scrub" may add new bad blocks >> > - Writes and ioctl() may clear bad blocks >> > >> > Add support to send sysfs notifications to sysfs "badblocks" file >> > under region and pmem directories when their badblocks information >> > is re-evaluated (but is not necessarily changed) during run-time. >> > >> > Signed-off-by: Toshi Kani >> > Cc: Dan Williams >> > Cc: Vishal Verma >> > Cc: Linda Knippers >> > --- >> > v2: Send notifications for the clearing case >> > --- >> >> This looks good to me, I've applied it, but I also want to extend the >> ndctl unit tests to cover this mechanism. > > Right. For the time being, would you mind to use the attached test > program for your sanity tests? It simply monitors sysfs notifications > and prints badblocks info... Sorry for inconvenience. > > Since I am not familiar with the ndctl unit tests and I am traveling for > the rest of the month, I may have to look into it after I am back. > No worries, I'll take a look at integrating this. Have a nice trip!