From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: Dan Williams <dan.j.williams@intel.com>
CC: "Verma, Vishal L" <vishal.l.verma@intel.com>,
        "Knippers, Linda" <linda.knippers@hpe.com>,
        "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] libnvdimm, pmem: Add sysfs notifications to badblocks
Thread-Topic: [PATCH v2] libnvdimm, pmem: Add sysfs notifications to badblocks
Thread-Index: AQHS48rXHia2DqmigUe4/diXsaUyG6ImdmGAgAG8HmCAAAxdAIAAAPVQ
Date: Sat, 17 Jun 2017 00:51:21 +0000
Message-ID: <CS1PR84MB010409051553B970CAF4B9F482C60@CS1PR84MB0104.NAMPRD84.PROD.OUTLOOK.COM>
References: <20170612222511.22030-1-toshi.kani@hpe.com>
 <CAPcyv4i03dU37tgqyRaMugGTqjagWeZ+WAtc7deJyZkkAbO9mA@mail.gmail.com>
 <CS1PR84MB0104A87F4AAB23AADF88656282C60@CS1PR84MB0104.NAMPRD84.PROD.OUTLOOK.COM>
 <CAPcyv4geo4mhj9Ly9ro+uAS0kLNbeGgv+2eUQr1cZbJfhPKQMw@mail.gmail.com>
In-Reply-To: <CAPcyv4geo4mhj9Ly9ro+uAS0kLNbeGgv+2eUQr1cZbJfhPKQMw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2017 00:51:21.0195
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0069
X-OriginatorOrg: hpe.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5H0pb3k018717
Content-Length: 1470
Lines: 33

> On Fri, Jun 16, 2017 at 5:35 PM, Kani, Toshimitsu <toshi.kani@hpe.com> wrote:
> >> On Mon, Jun 12, 2017 at 3:25 PM, Toshi Kani <toshi.kani@hpe.com> wrote:
> >> > Sysfs "badblocks" information may be updated during run-time that:
> >> >  - MCE, SCI, and sysfs "scrub" may add new bad blocks
> >> >  - Writes and ioctl() may clear bad blocks
> >> >
> >> > Add support to send sysfs notifications to sysfs "badblocks" file
> >> > under region and pmem directories when their badblocks information
> >> > is re-evaluated (but is not necessarily changed) during run-time.
> >> >
> >> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> >> > Cc: Dan Williams <dan.j.williams@intel.com>
> >> > Cc: Vishal Verma <vishal.l.verma@intel.com>
> >> > Cc: Linda Knippers <linda.knippers@hpe.com>
> >> > ---
> >> > v2: Send notifications for the clearing case
> >> > ---
> >>
> >> This looks good to me, I've applied it, but I also want to extend the
> >> ndctl unit tests to cover this mechanism.
> >
> > Right.  For the time being, would you mind to use the attached test
> > program for your sanity tests?  It simply monitors sysfs notifications
> > and prints badblocks info...  Sorry for inconvenience.
> >
> > Since I am not familiar with the ndctl unit tests and I am traveling for
> > the rest of the month, I may have to look into it after I am back.
> >
> 
> No worries, I'll take a look at integrating this. Have a nice trip!

Thanks Dan!!  I really appreciate it! 
-Toshi