Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752653AbdFQD10 (ORCPT ); Fri, 16 Jun 2017 23:27:26 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:5984 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752391AbdFQD1Y (ORCPT ); Fri, 16 Jun 2017 23:27:24 -0400 X-RM-TRANSID: 2ee55944a198532-08564 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee55944a1978fe-1b14e From: Haishuang Yan To: "David S. Miller" , Paolo Abeni , Alexei Starovoitov Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Haishuang Yan , Pravin B Shelar Subject: [PATCH v2 1/2] ip_tunnel: fix ip tunnel lookup in collect_md mode Date: Sat, 17 Jun 2017 11:27:10 +0800 Message-Id: <1497670031-2971-1-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 32 In collect_md mode, if the tun dev is down, it still can call ip_tunnel_rcv to receive on packets, and the rx statistics increase improperly. Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") Cc: Pravin B Shelar Signed-off-by: Haishuang Yan --- Change since v2: * Fix wrong recipient addresss --- net/ipv4/ip_tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c index 0f1d876..a3caba1 100644 --- a/net/ipv4/ip_tunnel.c +++ b/net/ipv4/ip_tunnel.c @@ -176,7 +176,7 @@ struct ip_tunnel *ip_tunnel_lookup(struct ip_tunnel_net *itn, return cand; t = rcu_dereference(itn->collect_md_tun); - if (t) + if (t && (t->dev->flags & IFF_UP)) return t; if (itn->fb_tunnel_dev && itn->fb_tunnel_dev->flags & IFF_UP) -- 1.8.3.1