Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752673AbdFQD13 (ORCPT ); Fri, 16 Jun 2017 23:27:29 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:49768 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752611AbdFQD10 (ORCPT ); Fri, 16 Jun 2017 23:27:26 -0400 X-RM-TRANSID: 2ee35944a19a53f-0855c X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee95944a19b55a-1ad62 From: Haishuang Yan To: "David S. Miller" , Paolo Abeni , Alexei Starovoitov Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Haishuang Yan Subject: [PATCH v2 2/2] ip6_tunnel: fix ip6 tunnel lookup in collect_md mode Date: Sat, 17 Jun 2017 11:27:11 +0800 Message-Id: <1497670031-2971-2-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1497670031-2971-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1497670031-2971-1-git-send-email-yanhaishuang@cmss.chinamobile.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 32 In collect_md mode, if the tun dev is down, it still can call __ip6_tnl_rcv to receive on packets, and the rx statistics increase improperly. Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") Cc: Alexei Starovoitov Signed-off-by: Haishuang Yan --- Change since v2: * Fix wrong recipient address --- net/ipv6/ip6_tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 6400726..25961c7 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c @@ -171,7 +171,7 @@ static struct net_device_stats *ip6_get_stats(struct net_device *dev) } t = rcu_dereference(ip6n->collect_md_tun); - if (t) + if (t && (t->dev->flags & IFF_UP)) return t; t = rcu_dereference(ip6n->tnls_wc[0]); -- 1.8.3.1