Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752629AbdFQDqj (ORCPT ); Fri, 16 Jun 2017 23:46:39 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34362 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752391AbdFQDqi (ORCPT ); Fri, 16 Jun 2017 23:46:38 -0400 From: Taeung Song To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim Subject: [PATCH v4 0/5] perf config: Bugfixes & Refactoring Date: Sat, 17 Jun 2017 12:46:32 +0900 Message-Id: <1497671192-20400-1-git-send-email-treeze.taeung@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1331 Lines: 45 Hi all, This is simple patchset for perf-config to fix small bugs and refactor code. I'd appreciate some feedback on this patchset. The code is also available at 'config/refactoring-v4' branch on git://github.com/taeung/linux-perf.git Thanks, Taeung v4: - rebase on current acme/perf/core - simplify commit log messages - remove needless two patches v3: - fix a bug of no checked 'ret' in the loop in cmd_config() (Arnaldo) - modify commit log messages to be more clear (Aranaldo) - return -1 if show_spec_config() cannot show the config - initialize 'ret' with -1 instead of 0 for more compact code in cmd_config() - Add a error message when perf_config_set__new() failed in cmd_config() v2: - there is no need to consider empty config file (Arnaldo) Taeung Song (5): perf config: Check error cases of {show_spec, set}_config() perf config: Refactor the code using 'ret' variable in cmd_config() perf config: Finally write changed configs on config file at a time perf config: Check not only section->from_system_config but also item's perf config: Autogenerate a config file if it does not exist on setting feature. tools/perf/builtin-config.c | 57 ++++++++++++++++++++++++++++++--------------- tools/perf/util/config.c | 5 +--- 2 files changed, 39 insertions(+), 23 deletions(-) -- 2.7.4