Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbdFQLTI convert rfc822-to-8bit (ORCPT ); Sat, 17 Jun 2017 07:19:08 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:8744 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752762AbdFQLTG (ORCPT ); Sat, 17 Jun 2017 07:19:06 -0400 From: Salil Mehta To: Andrew Lunn CC: "davem@davemloft.net" , "Zhuangyuzeng (Yisen)" , huangdaode , "lipeng (Y)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linuxarm Subject: RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework Thread-Topic: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework Thread-Index: AQHS5Jpnk4bbWRJFP0mlSPEY7mqpF6Ijcu4AgAV5ONA= Date: Sat, 17 Jun 2017 11:18:49 +0000 Message-ID: References: <20170613231035.494020-1-salil.mehta@huawei.com> <20170613231035.494020-3-salil.mehta@huawei.com> <20170614013750.GG23384@lunn.ch> In-Reply-To: <20170614013750.GG23384@lunn.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.160] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.59451027.000F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.2.25, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 513fd0f2ad9248bac8c7dff33f7edbdd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 927 Lines: 33 Hi Andrew, > -----Original Message----- > From: Andrew Lunn [mailto:andrew@lunn.ch] > Sent: Wednesday, June 14, 2017 2:38 AM > To: Salil Mehta > Cc: davem@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the > HNAE3 framework > > On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > > +static int __init hnae3_init(void) > > +{ > > + return 0; > > +} > > + > > .. > > > +subsys_initcall(hnae3_init); > > And the point of this is? > > Andrew This looks weird but not sure how we could have made sure HNAE is available before other 2 drivers could have loaded. Changing into module_init() means two other modules (dependent upon hnae) if loaded first will experience load time linking problems. Do you think this is okay? Thanks Salil