Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752866AbdFQLUt convert rfc822-to-8bit (ORCPT ); Sat, 17 Jun 2017 07:20:49 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7878 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752762AbdFQLUr (ORCPT ); Sat, 17 Jun 2017 07:20:47 -0400 From: Salil Mehta To: Andrew Lunn CC: "davem@davemloft.net" , "Zhuangyuzeng (Yisen)" , huangdaode , "lipeng (Y)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linuxarm Subject: RE: [PATCH V2 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver Thread-Topic: [PATCH V2 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver Thread-Index: AQHS5JpwRmJqIf0BOE2A84H0CqsYQ6IjfqoAgAVvWdA= Date: Sat, 17 Jun 2017 11:20:28 +0000 Message-ID: References: <20170613231035.494020-1-salil.mehta@huawei.com> <20170613231035.494020-8-salil.mehta@huawei.com> <20170614021950.GH23384@lunn.ch> In-Reply-To: <20170614021950.GH23384@lunn.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.160] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.5945108A.001D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.2.25, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: cdae61fc38be83051ebb326a0badd4b3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1483 Lines: 39 Hi Andrew, > -----Original Message----- > From: Andrew Lunn [mailto:andrew@lunn.ch] > Sent: Wednesday, June 14, 2017 3:20 AM > To: Salil Mehta > Cc: davem@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 7/8] net: hns3: Add Ethtool support to > HNS3 driver > > > + switch (media_type) { > > + case HNAE3_MEDIA_TYPE_FIBER: > > + cmd->base.port = PORT_FIBRE; > > + supported_caps = HNS3_LM_FIBRE_BIT | HNS3_LM_AUTONEG_BIT | > > + HNS3_LM_PAUSE_BIT | HNS3_LM_40000BASELR4_FULL_BIT | > > + HNS3_LM_10000BASEKR_FULL_BIT | > > + HNS3_LM_1000BASET_FULL_BIT; > > + /* TODO: add speed 100G/50G/25G when ethtool and linux > kernel > > + * is ready to support. > > Linux already has: > > linux/ethtool.h: ETHTOOL_LINK_MODE_25000baseCR_Full_BIT = 31, > linux/ethtool.h: ETHTOOL_LINK_MODE_25000baseKR_Full_BIT = 32, > linux/ethtool.h: ETHTOOL_LINK_MODE_25000baseSR_Full_BIT = 33, > linux/ethtool.h: ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT = 34, > linux/ethtool.h: ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT = 35, > linux/ethtool.h: ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT = 36, > linux/ethtool.h: ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT = 37, > linux/ethtool.h: ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT = 38, > linux/ethtool.h: ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT = 39, > > Andrew Sure thanks. Will consider using them. Salil