Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752916AbdFQNpw (ORCPT ); Sat, 17 Jun 2017 09:45:52 -0400 Received: from mail-qt0-f169.google.com ([209.85.216.169]:33538 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbdFQNpu (ORCPT ); Sat, 17 Jun 2017 09:45:50 -0400 MIME-Version: 1.0 In-Reply-To: <1497704579-29982-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1497704579-29982-1-git-send-email-sudipm.mukherjee@gmail.com> From: Andy Shevchenko Date: Sat, 17 Jun 2017 16:45:49 +0300 Message-ID: Subject: Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single parallel port card. To: Sudip Mukherjee Cc: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Alexander Gerasiov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 908 Lines: 29 On Sat, Jun 17, 2017 at 4:02 PM, Sudip Mukherjee wrote: > From: Alexander Gerasiov > > WCH CH382L is a PCI-E adapter with 1 parallel port. It is similair to CH382 > but serial ports are not soldered on board. Detected as > Serial controller: Device 1c00:3050 (rev 10) (prog-if 05 [16850]) > wch_ch382_2s1p, > + wch_ch382_0s1p, > /* wch_ch382_2s1p*/ { 1, { { 2, -1}, } }, > + /* wch_ch382_0s1p*/ { 1, { { 2, -1}, } }, > { 0x1c00, 0x3250, 0x1c00, 0x3250, 0, 0, wch_ch382_2s1p}, > + { 0x1c00, 0x3050, 0x1c00, 0x3050, 0, 0, wch_ch382_0s1p}, Just a nit, wouldn't be better to preserve alphanumerical sorting? (Exchange lines in above pairs) > + [wch_ch382_0s1p] = { ... > [sunix_2s1p] = { Similar here, though it's not visible in the patch. -- With Best Regards, Andy Shevchenko